Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/search: Added search bar and other minor ui fix #1176

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

ItsFlash10
Copy link
Contributor

@ItsFlash10 ItsFlash10 commented Sep 10, 2024

PR Fixes:

  • Added search bar back in the courses page and moved the siederbar trigger to the right since the sidebar is on the right side.
  • Fixed the siderbar UI

Resolves #1175

@siinghd @devsargam @hkirat

Screen.Recording.2024-09-10.at.11.59.18.AM.mov

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@ItsFlash10
Copy link
Contributor Author

@devsargam This PR includes a fix for the search API to return results for only the courses that a user has purchased, currently, it's showing the result from the entire DB as you mentioned.

@devsargam
Copy link
Collaborator

Where does this pr stands with the new addition of #1205
Is this still needed @ItsFlash10?

@ItsFlash10
Copy link
Contributor Author

Where does this pr stands with the new addition of #1205 Is this still needed @ItsFlash10?

This solves what you mentioned about current search is searching the entire courses in the db instead of user-specific purchases.

@devsargam
Copy link
Collaborator

Thank you sir

@devsargam devsargam merged commit 700e6b1 into code100x:main Oct 4, 2024
1 check failed
devsargam added a commit that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Search missing in the new UI
2 participants