refine script to fix videoplayer some play issue #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
minggo
reviewed
Jul 20, 2023
| this.videoPlayer.clip = this.videClip; | ||
| } | ||
| if (!this.videoPlayer.isPlaying) { | ||
| this.videoPlayer.play(); | ||
| } |
There was a problem hiding this comment.
Why need to check the status before playing? VideoPlayer will not check the status?
There was a problem hiding this comment.
Ok, it may cause to replay.
There was a problem hiding this comment.
Currently, we do not have this check in VideoPlayer. And different platform have different strategies when repeatly call play. So I think it's a foolproof way to check in script.
minggo
reviewed
Jul 20, 2023
| this.videoPlayer.play(); | ||
| } | ||
| else { | ||
| if (this.videoPlayer.remoteURL !== remoteURL) { | ||
| this.videoPlayer.remoteURL = remoteURL; |
minggo
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/cocos/3d-tasks/issues/10920
Play On AwakevideoPlayer.play()after load video source other than listening VideoPlayer.Event to prevent call play() on unpredictable time.Please do not merge before finishing test v3.8.0.
Rely on PR: cocos/cocos-engine#15782