Fix the issue that can not destroy Node in contract listener call back in Box2D #17701
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
dumganhar
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue:
open the project
Hello384_1.zip
then will see error message when two objects collides
Reason:
How to fix:
Indeed there are more codes should do check, but it is more common to destroy node in call back. And it invokes physics codes indirectly, so it is not easy to notice error usage here. If invoke other physics codes directly in call back is not allowed.
It works before v3.8.0 because of the PR: #14026. That PR will delay emitting contract listener. And this PR is reverted in #15564. I don't know why to revert the implementation.