Fix the display of WebGPU under the new pipeline with CSM, resolve the conflict between binding and render attachment, and optimize the memory pool. #17562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e conflict between binding and render attachment, and optimize the memory pool.
Interface Check ReportThis pull request does not change any public interfaces ! |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
star-e
approved these changes
Aug 20, 2024
star-e
added a commit
to star-e/cocos-engine
that referenced
this pull request
Aug 21, 2024
…solve the conflict between binding and render attachment, and optimize the memory pool. (cocos#17562)" This reverts commit 3dfdc02.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This pull request introduces significant changes to the rendering pipeline execution and resource management in the GengineJS/engine repository. Here's a summary of the key modifications:
Optimized texture and sampler binding in the
updatePerPassUBOfunction to reduce unnecessary bindings and improve performance.Introduced a new
RenderPassLayoutInfoclass to better manage render pass layouts and their associated resources.Refactored
DeviceRenderPassandDeviceComputePassclasses to improve handling of WebGPU under the new pipeline with Cascaded Shadow Maps (CSM).Updated the
ExecutorPoolsclass to optimize memory usage and resource management.Implemented changes to resolve conflicts between binding and render attachment, potentially improving rendering stability and efficiency.
These modifications aim to enhance the overall performance and compatibility of the engine, particularly for WebGPU rendering with the new pipeline and CSM implementation.