Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the render config of pipeline #17560

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

yanOO1497
Copy link
Contributor

@yanOO1497 yanOO1497 commented Aug 20, 2024

RT
Reply: cocos/3d-tasks#18454

Greptile Summary

This pull request modifies the render pipeline configuration in the engine features, introducing a more structured approach to pipeline selection.

  • Added new 'render-pipeline' feature in /editor/engine-features/render-config.json with 'custom-pipeline' and 'legacy-pipeline' options
  • Removed 'custom-pipeline-post-process' feature from the configuration
  • Set 'custom-pipeline' as the default option for the render pipeline
  • Categorized 'render-pipeline' under "graphics" and marked it as required and hidden
  • Ensured compatibility with existing schema and TypeScript definitions in schema.json and types.ts

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

Interface Check Report

This pull request does not change any public interfaces !

@star-e star-e merged commit df70e6a into cocos:v3.8.4 Aug 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants