Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the situation where the texture inside the FBO is destroyed when WebGPU switches scenes. #17547

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

GengineJS
Copy link
Contributor

@GengineJS GengineJS commented Aug 16, 2024

Greptile Summary

This pull request addresses an issue with texture destruction in WebGPU when switching scenes, focusing on modifications to the DeviceRenderPass class in the rendering executor.

  • Modified resetResource method in cocos/rendering/custom/executor.ts to prevent premature texture destruction
  • Added checks to ensure textures are only destroyed when necessary
  • Implemented new condition for rebuilding the framebuffer to maintain texture integrity
  • Improved handling of Framebuffer Object (FBO) resources during scene transitions

@GengineJS GengineJS requested a review from star-e August 16, 2024 06:09
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@GengineJS GengineJS changed the title Fixedthe situation where the texture inside the FBO is destroyed when WebGPU switches scenes. Fixed the situation where the texture inside the FBO is destroyed when WebGPU switches scenes. Aug 16, 2024
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@star-e star-e merged commit 25818aa into cocos:v3.8.4 Aug 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants