refine game activity #16420
Closed
refine game activity #16420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a076c7fb456e2d554c685690a7a29f5867d08f4f)
Interface Check ReportThis pull request does not change any public interfaces ! |
dumganhar
reviewed
Oct 13, 2023
| * application uses this to access binary assets bundled inside its own .apk | ||
| * file. | ||
| */ | ||
| AAssetManager* assetManager; |
There was a problem hiding this comment.
Global variables were not initialized.
dumganhar
reviewed
Oct 13, 2023
| inline ANativeWindow *getNativeWindow() const { return _nativeWindow; } | ||
| inline int getWindowId() const { return _windowId; } | ||
| inline int getWidth() const { return _width; } | ||
| inline int getHeight() const { return _height; } |
There was a problem hiding this comment.
The function return types is different with where they defined.
dumganhar
reviewed
Oct 13, 2023
|
|
||
| int running; | ||
| int destroyed; | ||
| ARect pendingContentRect; |
There was a problem hiding this comment.
Do these variables all need to be public?
There was a problem hiding this comment.
pendingContentRect can be removed temperary, others need to be declare as global.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: # #14627
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: