V3.8.2 enable resize inspector preview area height #16219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
doommm
reviewed
Sep 21, 2023
Comment on lines
+105
to
+107
| setTimeout(() => { | ||
| Editor.Message.broadcast('fbx-inspector:change-tab', panel.activeTab); | ||
| }); |
There was a problem hiding this comment.
因为 fbx 的头部区域也在初始化监听此广播事件，此为发送位置，需要等下监听位置初始化完成
doommm
reviewed
Sep 21, 2023
Comment on lines
+107
to
125
| :host > .container > .content > section > inspector-resize-preview { | ||
| position: absolute; | ||
| left: 0; | ||
| right: 0; | ||
| z-index: 10; | ||
| } | ||
|
|
||
| :host > .container > .content > section > inspector-resize-preview[area="header"] { | ||
| bottom: 0; | ||
| } | ||
|
|
||
| :host > .container > .content > section > inspector-resize-preview[area="footer"] { | ||
| top: 0; | ||
| } | ||
|
|
||
| :host > .container > .content > .content-header, | ||
| :host > .container > .content > .content-footer { | ||
| max-height: 80vh; | ||
| } |
There was a problem hiding this comment.
avoid using unnecessary nested selector and it's better not to reply on specific DOM structure. make it clear, make it simple
There was a problem hiding this comment.
Specific structure selector can reduce false matches.
doommm
approved these changes
Sep 22, 2023
VisualSJ
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #https://github.com/cocos/3d-tasks/issues/17386
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: