Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDL-related issues #16212

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Fix SDL-related issues #16212

merged 4 commits into from
Sep 8, 2023

Conversation

qiuguohua
Copy link
Contributor

@qiuguohua qiuguohua commented Sep 7, 2023

1.Fixed editbox input send message twice
2.Fixed when the window is hidden to send message twice 3.Fixed unresponsive right mouse button

Re: #

Changelog

https://github.com/cocos/3d-tasks/issues/17587#event-10241871963
https://github.com/cocos/3d-tasks/issues/17540#event-10229642660
https://github.com/cocos/3d-tasks/issues/17542#event-10227622750


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

2.Fixed when the window is hidden to send message twice
3.Fixed unresponsive right mouse button
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Interface Check Report

This pull request does not change any public interfaces !

@bluesky013
Copy link
Contributor

Are we considering using NSWindow consistently and having gfx maintain the CAMetalLayer?

@qiuguohua qiuguohua changed the title 1.Fixed editbox input send message twice. Fix SDL-related issues Sep 7, 2023
@qiuguohua qiuguohua closed this Sep 7, 2023
@qiuguohua qiuguohua reopened this Sep 7, 2023
@qiuguohua
Copy link
Contributor Author

@cocos-robot run test cases

@minggo minggo merged commit 3822786 into cocos:v3.8.1 Sep 8, 2023
47 of 49 checks passed
@qiuguohua qiuguohua deleted the v3.8.1_fix_bug branch December 7, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants