Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/meshopt #16200

Merged
merged 9 commits into from
Sep 8, 2023
Merged

Fix/meshopt #16200

merged 9 commits into from
Sep 8, 2023

Conversation

yiwenxue
Copy link
Contributor

@yiwenxue yiwenxue commented Sep 6, 2023

Re: #https://github.com/cocos/3d-tasks/issues/17619

Changelog

  • add missing part.
  • add fallback for platform doesn't support half as vertex attribute
  • complete document

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Interface Check Report

This pull request does not change any public interfaces !

@yiwenxue
Copy link
Contributor Author

yiwenxue commented Sep 6, 2023

@cocos-robot run test cases

1 similar comment
@yiwenxue
Copy link
Contributor Author

yiwenxue commented Sep 7, 2023

@cocos-robot run test cases

@yiwenxue yiwenxue closed this Sep 7, 2023
@yiwenxue yiwenxue reopened this Sep 7, 2023
@sushanhong
Copy link
Contributor

@cocos-robot run test cases

1 similar comment
@sushanhong
Copy link
Contributor

@cocos-robot run test cases

@sushanhong
Copy link
Contributor

@cocos-robot run test cases

1 similar comment
@sushanhong
Copy link
Contributor

@cocos-robot run test cases

@sushanhong
Copy link
Contributor

@cocos-robot run test cases

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

@yiwenxue, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
ios PASS PASS FAIL
mac PASS PASS PASS

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

@yiwenxue, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
android PASS PASS PASS

@stanleyljl stanleyljl merged commit b46cba6 into cocos:v3.8.1 Sep 8, 2023
24 checks passed
yiwenxue added a commit to yiwenxue/cocos-engine that referenced this pull request Sep 11, 2023
@yiwenxue
Fix/meshopt (cocos#16200)
53281ef 
* fix meshopt trigger

* add missing part

* add fallback for platform that doean't support half vertex attr

* fix tidy

* revert wrong code

* correct missing field

* optimize

* tune, fix bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumganhar dumganhar dumganhar left review comments

@stanleyljl stanleyljl stanleyljl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiwenxue @sushanhong @dumganhar @stanleyljl