Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi-layers lighting model and fix direct specular #15778

Merged
merged 9 commits into from
Jul 20, 2023

Conversation

jk20012001
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

@jk20012001, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

@github-actions
Copy link

@jk20012001, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

@github-actions
Copy link

@jk20012001, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

@github-actions
Copy link

@jk20012001, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

@jk20012001 jk20012001 changed the title Coat381 add multi-layer lighting model Jul 20, 2023
@jk20012001 jk20012001 changed the title add multi-layer lighting model add multi-layers lighting model and fix direct specular Jul 20, 2023
@jk20012001 jk20012001 merged commit 9cffcaa into cocos:v3.8.1 Jul 20, 2023
10 checks passed
@github-actions
Copy link

@jk20012001, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants