Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed scene._instantiate on native platforms. #15771

Merged
merged 5 commits into from
Jul 31, 2023
Merged

fixed scene._instantiate on native platforms. #15771

merged 5 commits into from
Jul 31, 2023

Conversation

dumganhar
Copy link
Contributor

Re: # https://github.com/cocos/3d-tasks/issues/17279

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar marked this pull request as draft July 19, 2023 06:28
minggo
minggo reviewed Jul 20, 2023
View reviewed changes
native/cocos/core/scene-graph/Scene.h Outdated
@@ -51,6 +51,8 @@ class Scene final : public Node {
void onBatchCreated(bool dontSyncChildPrefab) override;
bool destroy() override;

void updateWorldTransform() override {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ; is not needed.

@dumganhar dumganhar marked this pull request as ready for review July 24, 2023 02:44
@dumganhar dumganhar changed the title fixed scene._instantiate/updateWorldTransform on native platforms. fixed scene._instantiate on native platforms. Jul 24, 2023
@minggo minggo merged commit 715d5d1 into cocos:v3.8.1 Jul 31, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggo minggo minggo approved these changes

@knoxHuang knoxHuang knoxHuang approved these changes

@PatriceJiang PatriceJiang PatriceJiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dumganhar @minggo @knoxHuang @PatriceJiang