Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Build Panel: Add resizeableActivity/maxAspectRatio #15713

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

PatriceJiang
Copy link
Contributor

@PatriceJiang PatriceJiang commented Jul 13, 2023

Re: #15057

This PR replaces the previous unsafe method of using regular expressions to parse and modify the AndroidManifest.xml file in the project. It introduces the use of the xml2js library, which provides a safer and more reliable way to handle XML parsing and manipulation. Additionally, it adds the resizeableActivity attribute for the specified activity.

Changelog

  • Add xml2js package to parse AndroidManifest.xml
  • Update resizeableActivity attribute
  • Add Max Aspect Ratio field

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@PatriceJiang PatriceJiang added this to the V3.8.1 milestone Jul 13, 2023
@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@PatriceJiang PatriceJiang marked this pull request as ready for review July 13, 2023 09:33
@PatriceJiang PatriceJiang requested a review from minggo July 13, 2023 09:33
@minggo
Copy link
Contributor

minggo commented Jul 14, 2023

@PatriceJiang please attach the screenshot of the build panel.

@PatriceJiang
Copy link
Contributor Author

image

@PatriceJiang
Copy link
Contributor Author

image

Add Max Aspect Ratio field

@minggo
Copy link
Contributor

minggo commented Aug 16, 2023

Please fix the CI issue.

@minggo minggo merged commit 23f2227 into cocos:v3.8.1 Aug 16, 2023
10 checks passed
@minggo minggo removed this from the V3.8.1 milestone Aug 17, 2023
@PatriceJiang PatriceJiang changed the title Android Build Panel: Add resizeableActivity Option Android Build Panel: Add resizeableActivity/maxAspectRatio Option Aug 30, 2023
@PatriceJiang PatriceJiang changed the title Android Build Panel: Add resizeableActivity/maxAspectRatio Option Android Build Panel: Add resizeableActivity/maxAspectRatio Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants