Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary code #15687

Merged
merged 7 commits into from
Aug 18, 2023
Merged

remove unnecessary code #15687

merged 7 commits into from
Aug 18, 2023

Conversation

SantyWang
Copy link
Contributor

@SantyWang SantyWang commented Jul 12, 2023

Re: #

Changelog

  • remove unnecessary code vertexrol, vertexrow

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@SantyWang SantyWang closed this Jul 21, 2023
@SantyWang SantyWang reopened this Jul 21, 2023
@SantyWang
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

@holycanvas, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL 2d-rendering-in-3d 2d-rendering-in-3d
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

@SantyWang
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Interface Check Report

This pull request does not change any public interfaces !

@SantyWang
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

@holycanvas, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios FAIL FAIL
android PASS PASS FAIL rich-text-long-string-truncation
mac PASS PASS PASS

@SantyWang
Copy link
Contributor Author

@cocos-robot run test cases

@SantyWang
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

@holycanvas, Please check the result of run test cases:

Task Details

@github-actions
Copy link

@holycanvas, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL planar-shadow,material-upgrade,label-cacheMode,label-align,ttf-font
android PASS PASS FAIL planar-shadow,material-upgrade

@SantyWang SantyWang merged commit daa4a4f into cocos:v3.8.1 Aug 18, 2023
10 checks passed
@SantyWang SantyWang deleted the v3.8.0-2d-patch.2 branch August 18, 2023 06:40
cocos-robot pushed a commit to cocos-robot/engine that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants