New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.8.1 add spine jsb apis #15674

Merged

SantyWang merged 32 commits into cocos:v3.8.1 from zxx43:3.8.1-spine

Aug 11, 2023

Contributor

zxx43 commented Jul 11, 2023

Re: #

Changelog

Continuous Integration

This pull request:

needs automatic test cases check.

Manual trigger with @cocos-robot run test cases afterward.
does not change any runtime related code or build configuration

If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

changes public API, and have ensured backward compatibility with deprecated features.
affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
affects file structure of the build package or build configuration which requires user project upgrade.
introduces breaking changes, please list all changes, affected features and the scope of violation.

zxx43 added 9 commits

June 20, 2023 17:31


          open some spine apis

d6dd7e3


          add some apis

b50bf53


          add spine jsb convert

7d17de5


          add some manual interfaces

8708f2f


          fix some jsb

4152ef5


          fix getAttachments

f6e685a


          remove findAttachmentsForSlot

691c00e


          manual VertexEffect::begin

9ab9d38


          remove SkinEntry

github-actions bot commented Jul 11, 2023

Interface Check Report

This pull request does not change any public interfaces !

SantyWang requested a review from dumganhar

July 11, 2023 03:38

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_conversions_spec.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_conversions_spec.h Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/tools/swig-config/spine.i Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/editor-support/spine-creator-support/Vector2.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

dumganhar reviewed

View reviewed changes

native/cocos/bindings/manual/jsb_spine_manual.cpp Outdated Show resolved Hide resolved

zxx43 added 6 commits

July 13, 2023 09:57


          Merge branch 'v3.8.1' into 3.8.1-spine

fa30dd0


          fix ci

ce255ed


          Merge branch '3.8.1-spine' of github.com:zxx43/engine into 3.8.1-spine

6d929e8


          fix ci

a02eb3f


          change include

354f430


          fix SWIGINTERN

bce3db6

zxx43 added the PR: Do not merge label


          fix test-case

ccde279

dumganhar reviewed

View reviewed changes

native/tools/swig-config/spine.i Show resolved Hide resolved

zxx43 removed the PR: Do not merge label

zxx43 added 7 commits

July 17, 2023 16:03


          use rename

b20a0df


          check spine instance null

3f90c54


          fix eslint

d14ee59


          Merge branch 'v3.8.1' into 3.8.1-spine

2f75f77


          fix eslint

f7a1e61


          add some missing apis

7fce084


          add getAttachmentByName

fee88de

SantyWang approved these changes

View reviewed changes

Contributor

dumganhar commented Aug 3, 2023

There is a conflict which needs to be fixed.

zxx43 added 3 commits

August 3, 2023 17:57


          Merge branch 'v3.8.1' into 3.8.1-spine

777bd08


          modify jsb api

f0dbe6f


          Merge branch '3.8.1-spine' of github.com:zxx43/engine into 3.8.1-spine

2e5fb35

Contributor

SantyWang commented Aug 9, 2023

@cocos-robot run test cases

dumganhar approved these changes

View reviewed changes


          fix eslint

9ce4096

github-actions bot commented Aug 9, 2023

@zxx43, Please check the result of run test cases:

Test Platform: PR-Test
Editor Version: v3.8.1
Task Result: FAIL
Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/68a40251-9d8e-492f-bbe0-64bbbf4c1485/-1
GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/5804176207

Task Details

Platform	build	boot	runned	crashScene	FailScene
web-mobile	PASS	PASS	PASS
windows	PASS	PASS	FAIL		label-cacheMode,label-align,ttf-font
ios	FAIL		FAIL
android	PASS	PASS	FAIL		rich-text-long-string-truncation
mac	FAIL		FAIL

Contributor Author

zxx43 commented Aug 9, 2023

@cocos-robot run test cases

github-actions bot commented Aug 9, 2023

@zxx43, Please check the result of run test cases:

Test Platform: PR-Test
Editor Version: v3.8.1
Task Result: FAIL
Task URL: https://cctest.cocos.org/#/reportview/PR-TEST/9dc5a0b6-1002-4c0b-b692-da7dbae5b8e5/-1
GitHub Action: https://github.com/cocos/cocos-engine/actions/runs/5805835294

Task Details

Platform	build	boot	runned	crashScene	FailScene
web-mobile	PASS	PASS	PASS
windows	PASS	PASS	FAIL		label-cacheMode,label-align,ttf-font
ios	FAIL		FAIL
android	PASS	PASS	FAIL		rich-text-long-string-truncation
mac	PASS	PASS	PASS

zxx43 changed the title ~~3.8.1 spine~~ 3.8.1 add spine jsb apis

SantyWang merged commit 60b5a7d into cocos:v3.8.1

23 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet