Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine visible modifier behavior for uuid, name, enabled on nodes and components #15671

Merged

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Jul 11, 2023

Re: #https://github.com/cocos/3d-tasks/issues/9035

Changelog

  • Refine visible modifier behavior for uuid, name, enabled on nodes and components

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@@ -48,6 +48,10 @@
width: 20px;
}

.header > .active[hidden] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不需要

@knoxHuang knoxHuang removed the request for review from lealzhan July 11, 2023 06:01
@knoxHuang knoxHuang force-pushed the 添加组件-enabled-显示与隐藏的功能 branch from 3a12517 to 9203c14 Compare July 12, 2023 09:57
@knoxHuang knoxHuang changed the title add handling of component enabled ui display add alwaysEnabled modifier to the component Jul 12, 2023
@knoxHuang knoxHuang force-pushed the 添加组件-enabled-显示与隐藏的功能 branch from eb257fe to ed16ede Compare July 13, 2023 02:01
@knoxHuang knoxHuang changed the title add alwaysEnabled modifier to the component Refine visible modifier behavior for uuid, name, enabled on nodes and components Jul 13, 2023
Comment on lines 41 to 42
import { DEBUG, EDITOR } from 'internal:constants';
import { Vec3, error, warn, CCClass } from '../../../core';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { DEBUG, EDITOR } from 'internal:constants';
import { Vec3, error, warn, CCClass } from '../../../core';
import { DEBUG } from 'internal:constants';
import { Vec3, error, warn } from '../../../core';

@knoxHuang knoxHuang force-pushed the 添加组件-enabled-显示与隐藏的功能 branch from 6273f8b to 49867ff Compare July 14, 2023 06:30
@knoxHuang knoxHuang force-pushed the 添加组件-enabled-显示与隐藏的功能 branch from 49867ff to 4468bf2 Compare July 14, 2023 06:32
@VisualSJ VisualSJ merged commit 8e0e500 into cocos:develop Jul 17, 2023
10 checks passed
cocos-robot pushed a commit to cocos-robot/engine that referenced this pull request Jul 17, 2023
minggo pushed a commit that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants