-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine visible modifier behavior for uuid, name, enabled on nodes and components #15671
Merged
The head ref may contain hidden characters: "\u6DFB\u52A0\u7EC4\u4EF6-enabled-\u663E\u793A\u4E0E\u9690\u85CF\u7684\u529F\u80FD"
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsen2010
reviewed
Jul 11, 2023
@@ -48,6 +48,10 @@ | |||
width: 20px; | |||
} | |||
|
|||
.header > .active[hidden] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不需要
arsen2010
approved these changes
Jul 11, 2023
VisualSJ
approved these changes
Jul 11, 2023
knoxHuang
force-pushed
the
添加组件-enabled-显示与隐藏的功能
branch
from
July 12, 2023 09:57
3a12517
to
9203c14
Compare
knoxHuang
changed the title
add handling of component enabled ui display
add alwaysEnabled modifier to the component
Jul 12, 2023
knoxHuang
force-pushed
the
添加组件-enabled-显示与隐藏的功能
branch
from
July 13, 2023 02:01
eb257fe
to
ed16ede
Compare
knoxHuang
changed the title
add alwaysEnabled modifier to the component
Refine visible modifier behavior for uuid, name, enabled on nodes and components
Jul 13, 2023
shrinktofit
reviewed
Jul 13, 2023
Comment on lines
41
to
42
import { DEBUG, EDITOR } from 'internal:constants'; | ||
import { Vec3, error, warn, CCClass } from '../../../core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
import { DEBUG, EDITOR } from 'internal:constants'; | |
import { Vec3, error, warn, CCClass } from '../../../core'; | |
import { DEBUG } from 'internal:constants'; | |
import { Vec3, error, warn } from '../../../core'; |
knoxHuang
force-pushed
the
添加组件-enabled-显示与隐藏的功能
branch
from
July 14, 2023 06:30
6273f8b
to
49867ff
Compare
knoxHuang
force-pushed
the
添加组件-enabled-显示与隐藏的功能
branch
from
July 14, 2023 06:32
49867ff
to
4468bf2
Compare
VisualSJ
approved these changes
Jul 17, 2023
cocos-robot
pushed a commit
to cocos-robot/engine
that referenced
this pull request
Jul 17, 2023
minggo
pushed a commit
that referenced
this pull request
Aug 21, 2023
…15747) Co-authored-by: cocos-robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #https://github.com/cocos/3d-tasks/issues/9035
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: