Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless code #15670

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Remove useless code #15670

merged 2 commits into from
Jul 11, 2023

Conversation

SantyWang
Copy link
Contributor

@SantyWang SantyWang commented Jul 10, 2023

Re: #

Changelog

  • Remove useless code

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@SantyWang SantyWang changed the title V3.8.1 2d patch Remove useless code Jul 10, 2023
@github-actions
Copy link

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -3296,9 +3296,8 @@
         updatePass(comp: UIRenderer): void;
         updateTexture(frame: SpriteFrame | __private._cocos_asset_assets_texture_base__TextureBase): void;
         updateHash(): void;
         updateRenderData(comp: UIRenderer, frame: SpriteFrame | __private._cocos_asset_assets_texture_base__TextureBase): void;
-        updateSizeNPivot(width: number, height: number, pivotX: number, pivotY: number): void;
         clear(): void;
         static createStaticVBAccessor(attributes: gfx.Attribute[], vCount?: number, iCount?: number): __private._cocos_2d_renderer_static_vb_accessor__StaticVBAccessor;
     }
     /**

@SantyWang
Copy link
Contributor Author

@cocos-robot run test cases

@SantyWang SantyWang merged commit ddc19f1 into cocos:v3.8.1 Jul 11, 2023
11 checks passed
@SantyWang SantyWang deleted the v3.8.1-2d-patch branch July 11, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants