-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Improve interacive preview #15655
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
dogeFu
approved these changes
Jul 11, 2023
moshuying
changed the title
[Bug] Improve interacive preview
[feature] Improve interacive preview
Jul 11, 2023
arsen2010
reviewed
Jul 11, 2023
arsen2010
approved these changes
Jul 11, 2023
moshuying
changed the title
[feature] Improve interacive preview
[Feature] Improve interacive preview
Jul 13, 2023
arsen2010
approved these changes
Aug 3, 2023
VisualSJ
reviewed
Aug 4, 2023
VisualSJ
reviewed
Aug 14, 2023
await callModelPreviewFunction('onMouseDown', { x: event.x, y: event.y, button: event.button }); | ||
|
||
async function keydown(event) { | ||
await callModelPreviewFunction('onKeyDown', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Shouldn't a generic keydown event be triggered after mousedown?
- If it's an event on the document, should we still use 'onKeyDown'? What should we name it if we need to listen to events on the canvas in the future?
VisualSJ
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
https://github.com/cocos/3d-tasks/issues/15470
https://github.com/cocos/3d-tasks/issues/14387
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: