Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve interacive preview #15655

Merged
merged 10 commits into from
Aug 15, 2023

Conversation

moshuying
Copy link
Contributor

@moshuying moshuying commented Jul 7, 2023

Re: #
https://github.com/cocos/3d-tasks/issues/15470
https://github.com/cocos/3d-tasks/issues/14387

Changelog

  • Improve interacive preview

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@moshuying moshuying requested a review from arsen2010 July 7, 2023 10:25
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Interface Check Report

This pull request does not change any public interfaces !

@moshuying moshuying changed the title [Bug] Improve interacive preview [feature] Improve interacive preview Jul 11, 2023
@moshuying moshuying changed the title [feature] Improve interacive preview [Feature] Improve interacive preview Jul 13, 2023
editor/inspector/assets/fbx/preview.js Outdated Show resolved Hide resolved
editor/inspector/assets/fbx/preview.js Show resolved Hide resolved
editor/inspector/assets/material-header.js Outdated Show resolved Hide resolved
editor/inspector/assets/material-header.js Outdated Show resolved Hide resolved
editor/inspector/assets/material-header.js Show resolved Hide resolved
editor/inspector/assets/skeleton-preview.js Outdated Show resolved Hide resolved
await callModelPreviewFunction('onMouseDown', { x: event.x, y: event.y, button: event.button });

async function keydown(event) {
await callModelPreviewFunction('onKeyDown', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Shouldn't a generic keydown event be triggered after mousedown?
  2. If it's an event on the document, should we still use 'onKeyDown'? What should we name it if we need to listen to events on the canvas in the future?

@VisualSJ VisualSJ merged commit 7a554ea into cocos:v3.8.1 Aug 15, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants