-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some eslint error #15590
fix some eslint error #15590
Conversation
@@ -400,7 +400,7 @@ export class LetterAtlas { | |||
} | |||
|
|||
public getLetterDefinitionForChar (char: string, labelInfo: ILabelInfo): any { | |||
const hash = char.charCodeAt(0) + labelInfo.hash; | |||
const hash = char.charCodeAt(0).toString() + labelInfo.hash; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As key of letterDefinitions
is string, so use string here.
@@ -92,7 +92,7 @@ function parseType (val, type, className, propName): void { | |||
if (type.length > 0) { | |||
val.type = type = type[0]; | |||
} else { | |||
return errorID(5508, className, propName); | |||
errorID(5508, className, propName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should keep return
logic;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type is void.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but we should not execute the code below.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: