Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should remove game activity on Android? #14627

Closed
minggo opened this issue Mar 21, 2023 · 3 comments
Closed

Should remove game activity on Android? #14627

minggo opened this issue Mar 21, 2023 · 3 comments

Comments

@minggo
Copy link
Contributor

minggo commented Mar 21, 2023

Game activity is a heavy sdk, we should re-consider to use it or not.

@bofeng-song
Copy link
Contributor

The main tasks of GameActivity currently are:

  1. Handling of the joystick, which was previously handled in the Activity;
    === After removal, only the surfaceView that currently has focus can handle events in multiple windows. Will this meet the expectations of developers?
  2. Passing of Activity lifecycle, managing the native lifecycle (library load & unload)
    === After removal, will there be any issues with the android_native_app_glue lifecycle and event dispatching, as well as thread forwarding?
  3. After removing GameActivity, can the corresponding code in GameActivity.cpp be retained, and is it necessary to retain it?

@minggo
Copy link
Contributor Author

minggo commented May 17, 2023

As engine will finally run in an activity. So i think there is not problem. We may ask the activity to do the same thing that game activity did.

Of course, we should consider:

  • why need game activity, the pros and cons

@bofeng-song
Copy link
Contributor

bofeng-song commented Sep 8, 2023

Need to do:

  • Lifecycle
  • Controller Input
  • MultiWindow(windowId)
  • move Swappy files to libCocos & remove game sdk(containe jar & external files)

@bofeng-song bofeng-song mentioned this issue Oct 13, 2023
6 tasks
@minggo minggo closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants