metrics: remove re-login requirement for loading PCP metrics #21075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the switch to the python PCP implementation the metrics page no longer needs to re-login to load the new pcp manifest. The Python bridge will re-attempt import the PCP module and then load metrics as expected with one minor issue that uninstalling python3-pcp keeps the PCP module in memory.
|
The test failures seem to be due to a re-render which closes the metrcis dialog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the switch to the python PCP implementation the metrics page no longer needs to re-login to load the new pcp manifest. The Python bridge will re-attempt import the PCP module and then load metrics as expected with one minor issue that uninstalling python3-pcp keeps the PCP module in memory.