shell: Remove workaround for Chrome crash #21074
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And rewrite much of the state handling to make it easier to understand. Specifically, the old Index and MachineIndex classes and their complicated interactions have been replaced with a hopefully much more straightforward ShellState class. However, the existing React components such as CockpitHosts and TopNav have not been significantly touched. The API for launching the HostModal dialogs has been changed to make it more suitable for a later rewrite with Dialogs.run() ala pkg/lib/cockpit-connect-ssh.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Something unknown has changed during the rewrite of the shell and the crash isn't triggered anymore. Was it ever real? Or was it just a dream?
mvollmer
force-pushed
the
shell-remove-chrome-crash-workaround
branch
from
5e94aa4
to
0ae6019
Compare
cockpituous
reviewed
Oct 3, 2024
| frame: f, | ||
| active, | ||
| selected: active, | ||
| displayName: f.host === "localhost" ? "/" + f.path : f.host + ":/" + f.path, |
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+113
to
+116
| if (machine.restarting) { | ||
| title = _("The machine is rebooting"); | ||
| message = ""; | ||
| } else if (connecting) { |
There was a problem hiding this comment.
These 4 added lines are not executed by any test.
| if (frame.ready && iframe.getAttribute("data-ready") == null) | ||
| iframe.setAttribute("data-ready", "1"); | ||
| else if (!frame.ready && iframe.getAttribute("data-ready")) | ||
| iframe.removeAttribute("data-ready"); |
There was a problem hiding this comment.
This added line is not executed by any test.
| if (frame.loaded && iframe.getAttribute("data-loaded") == null) | ||
| iframe.setAttribute("data-loaded", "1"); | ||
| else if (!frame.loaded && iframe.getAttribute("data-loaded")) | ||
| iframe.removeAttribute("data-loaded"); |
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+178
to
+179
| style === "auto") || | ||
| style === "dark") { |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
Comment on lines
+153
to
+156
| self.search = function(prop, value) { | ||
| for (const x in self.items) { | ||
| if (self.items[x][prop] === value) | ||
| return self.items[x]; |
There was a problem hiding this comment.
These 4 added lines are not executed by any test.
Comment on lines
+188
to
+192
| function component_checksum(machine, path) { | ||
| const parts = path.split("/"); | ||
| const pkg = parts[0]; | ||
| if (machine.manifests && machine.manifests[pkg] && machine.manifests[pkg][".checksum"]) | ||
| return "$" + machine.manifests[pkg][".checksum"]; |
There was a problem hiding this comment.
These 5 added lines are not executed by any test.
| export function compute_frame_url(machine, path) { | ||
| let base, checksum; | ||
| if (machine.manifests && machine.manifests[".checksum"]) | ||
| checksum = "$" + machine.manifests[".checksum"]; |
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+202
to
+204
| if (checksum && checksum == component_checksum(machine, path)) { | ||
| if (machine.connection_string === "localhost") | ||
| base = ".."; |
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
| if (machine.connection_string === "localhost") | ||
| base = ".."; | ||
| else | ||
| base = "../../" + checksum; |
There was a problem hiding this comment.
This added line is not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something unknown has changed during the rewrite of the shell and the
crash isn't triggered anymore. Was it ever real? Or was it just a
dream?
This could be part of #21012 if it turns out be robust.