cockpit-certificate-ensure: soften the certificate generation #21069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certificate generation now works in the following cases - Certificate and key files do not exist. - Only the certificate file does not exist. - Only the key file does not exist. - The certificate file is empty. - The key file is empty.
jmlemetayer
force-pushed
the
fix-cockpit-certificate-ensure
branch
from
4a8a6cc
to
e44a7b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use cockpit in an embedded device, and it can happen that the power is suddenly cut off. So the file system is not synchronized and the last file system actions are lost.
If generating the self-signed certificate was one of them, you end up with empty files. And the next time you reboot, cockpit won't be able to start because
cockpit-certificate-ensurewill fail.These commits prevent failure on empty files and force a new generation. In addition, we explicitly request file system synchronization after generation.