Deprecate fslist1 channel #21055
Merged
Deprecate fslist1 channel #21055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to deprecate fslist1.
fsinfo supersedes it, and we don't want new code to use this channel.
This was the last user of the old fslist1 channel in all known Cockpit projects. Part of cockpit-project#19999
martinpitt
force-pushed
the
file-autocomplete-fslist
branch
from
18c9798
to
34b46b4
Compare
cockpituous
reviewed
Sep 30, 2024
| @@ -91,38 +93,25 @@ export class FileAutoComplete extends React.Component { | |||
|
|
|||
| onCreateOption(newValue) { | |||
| this.setState(prevState => ({ | |||
| displayFiles: [...prevState.displayFiles, { type: "file", path: newValue }] | |||
| displayFiles: [...prevState.displayFiles, { type: "reg", path: newValue }] | |||
There was a problem hiding this comment.
This added line is not executed by any test.
| fsinfo(path, ['type', 'entries'], { superuser: this.props.superuser }) | ||
| .then(info => { | ||
| const results = []; | ||
| for (const name in info.entries ?? {}) { |
There was a problem hiding this comment.
This added line is not executed by any test.
| const results = []; | ||
| for (const name in info.entries ?? {}) { | ||
| const type = info.entries[name].type; | ||
| if (!this.props.onlyDirectories || type == 'dir') |
There was a problem hiding this comment.
This added line is not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19999