Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell: Make it all reacty #21012

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

shell: Make it all reacty #21012

wants to merge 3 commits into from

Commits on Oct 3, 2024

  1. shell: Require confirmation before connecting to remote machines

    @mvollmer
    mvollmer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9bb1ad9 View commit details
    Browse the repository at this point in the history

  2. shell: Take docs from the correct manifest item 

    Fixes cockpit-project#21040
    @mvollmer
    mvollmer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f1d0192 View commit details
    Browse the repository at this point in the history

  3. shell: Use a top-level React component 

    And rewrite much of the state handling to make it easier to
understand.

Specifically, the old Index and MachineIndex classes and their
complicated interactions have been replaced with a hopefully much more
straightforward ShellState class.

However, the existing React components such as CockpitHosts and TopNav
have not been significantly touched.

The API for launching the HostModal dialogs has been changed to make
it more suitable for a later rewrite with Dialogs.run() ala
pkg/lib/cockpit-connect-ssh.
    @mvollmer
    mvollmer committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d4b3297 View commit details
    Browse the repository at this point in the history