workflows: Switch anaconda trigger COPR polling to timestamp comparison #19494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expecting the branch'es HEAD SHA does not work for proposed branches which are behind the target branch (i.e. usually `main`). For those, the packit source RPM build does a merge first, which produces an unpredictable SHA, which ends up as the COPR package'es version. Switch to a time based approach: Parse the timestamp from the package version, and wait until it is newer than the most recent push to the target branch. https://issues.redhat.com/browse/COCKPIT-1071
martinpitt
added
the
no-test
martinpitt
added
the
.github-changes
jelly
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expecting the branch'es HEAD SHA does not work for proposed branches which are behind the target branch (i.e. usually
main). For those, the packit source RPM build does a merge first, which produces an unpredictable SHA, which ends up as the COPR package'es version.Switch to a time based approach: Parse the timestamp from the package version, and wait until it is newer than the most recent push to the target branch.
https://issues.redhat.com/browse/COCKPIT-1071
I tested this and a few failed other approaches in martinpitt#19 . We saw this failure in the wild here: #19477 (comment)