test: Drop locale change check from TestPages.testBasic #19028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python bridge does not dynamically change its locale from `Accept-Languages:`, but just defaults to the standard environment of the logged in machine. We decided to not reimplement this in the pybridge, as that is weird, error prone, and a corner case: No other Linux command line software does that, it won't change the locale of existing running programs which got spawned before changing the language (as that's impossible), the code was making assumptions about locale names and availability, and we take very little human readable text directly from command-line programs, most of it gets interpreted, formatted, and translated in the UI.
martinpitt
added
no-test
|
@allisonkarlitskaya @mvollmer I'd appreciate both of your opinions about my justification. It would also not be hard to actually implement this feature in the pybridge, but I lean towards dropping it. |
4 tasks
allisonkarlitskaya
approved these changes
Jun 27, 2023
Because it's very expensive, and translations are the same on all OSes. So we picked the one where we know we have all locales. |
As long as it has that functionality, I think it makes sense to continue to test it, so there's no hurry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python bridge does not dynamically change its locale from
Accept-Languages:, but just defaults to the standard environment of the logged in machine.We decided to not reimplement this in the pybridge, as that is weird, error prone, and a corner case: No other Linux command line software does that, it won't change the locale of existing running programs which got spawned before changing the language (as that's impossible), the code was making assumptions about locale names and availability, and we take very little human readable text directly from command-line programs, most of it gets interpreted, formatted, and translated in the UI.
Spotted in PR #19011 with this failure.