test: Fix shebang in TestUpdates.testKpatch #19027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial empty line in the mocked /usr/local/bin/kpatch causes execve() to fail with `ENOEXEC` "Exec format error". The shell and the C bridge paper over this by falling back to interpreting the file as a shell script, but Python's subprocess gives up at this point.
martinpitt
added
no-test
4 tasks
jelly
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial empty line in the mocked /usr/local/bin/kpatch causes execve() to fail with
ENOEXEC"Exec format error". The shell and the C bridge paper over this by falling back to interpreting the file as a shell script, but Python's subprocess gives up at this point.Fixes TestUpdates.testKpatch with the Python bridge. That runs only on RHEL, so we didn't see it yet. Spotted in #19011