chore: Remove Select and use FormSelect

cockpit-project · May 24, 2023 · 41102b5 · 41102b5
1 parent d4844cf
commit 41102b5
Showing 1 changed file with 2 additions and 26 deletions.
diff --git a/src/ContainerHeader.jsx b/src/ContainerHeader.jsx
@@ -3,21 +3,9 @@ import cockpit from 'cockpit';
 import { FormSelect, FormSelectOption } from "@patternfly/react-core/dist/esm/components/FormSelect";
 import { SearchInput } from "@patternfly/react-core/dist/esm/components/SearchInput";
 import { Toolbar, ToolbarContent, ToolbarItem } from "@patternfly/react-core/dist/esm/components/Toolbar";
-import { Select, SelectOption } from '@patternfly/react-core';
 const _ = cockpit.gettext;
 
 const ContainerHeader = ({ user, twoOwners, ownerFilter, handleOwnerChanged, textFilter, handleFilterChanged }) => {
-    const [isOpenOwnersFilter, setIsOpenOwnersFilter] = React.useState(false);
-    // const toggleRef = React.useRef();
-    const onSelect = (event, selection) => {
-        handleOwnerChanged(selection);
-        setIsOpenOwnersFilter(false);
-    };
-
-    const clearSelection = () => {
-        handleOwnerChanged("All");
-        setIsOpenOwnersFilter(false);
-    };
     return (
         <Toolbar className="pf-m-page-insets">
             <ToolbarContent>
@@ -27,23 +15,11 @@ const ContainerHeader = ({ user, twoOwners, ownerFilter, handleOwnerChanged, tex
                             {_("Owner")}
                         </ToolbarItem>
                         <ToolbarItem>
-                            {/* <FormSelect id="containers-containers-owner" value={ownerFilter} onChange={handleOwnerChanged}>
+                            <FormSelect id="containers-containers-owner" value={ownerFilter} onChange={handleOwnerChanged}>
                                 <FormSelectOption value='user' label={user} />
                                 <FormSelectOption value='system' label={_("System")} />
                                 <FormSelectOption value='all' label={_("All")} />
-                            </FormSelect> */}
-                            {/* Select bug: toggle is not a function? */}
-                            <Select
-                                variant="typeahead"
-                                onToggle={(_, isOpen) => setIsOpenOwnersFilter(isOpen)}
-                                onSelect={onSelect}
-                                isOpen={isOpenOwnersFilter}
-                                onClear={clearSelection}
-                                selections={ownerFilter}>
-                                <SelectOption key="user" value={user} />
-                                <SelectOption key="system" value={_("System")} />
-                                <SelectOption key="all" value={_("All")} />
-                            </Select>
+                            </FormSelect>
                         </ToolbarItem>
                     </>
                 }