Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing spacing between input and form helper text solves #1164 #1354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashutosh7i
Copy link

Hello @jelly & @KKoukiou , i have worked on this issue,

Image with issue-

Screenshot from 2023-12-17 01-55-22

After my Solution to the issue-
image

The fix i implemented is that i replaced

<FormHelper ... /> component

with the official component-

<HelperText>
                    <HelperTextItem variant="error">{ ... } </HelperTextItem>
</HelperText>

image

And tweaked css in Machines.scss

image

this workaround fixed the issue of missing spacing between input and helper text solving #1164

Copy link
Member

@garrett garrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement, but why are the spaces different?

"Name should not be empty" has 13 pixels of space between the form and the string.

While the rest have 8 px.

PatternFly has 10px.

It seems your fonts are larger though (not the default), so the references above don't matter when comparing to PatternFly (which also doesn't use px to set these values, of course), so I don't know which is correct here, but I do know that they're inconsistent.

So I've checked locally on my machine and it seems the first one here is 10px and the rest are 6px. The first is correct; the rest still are not correct.

image

@garrett
Copy link
Member

garrett commented Jan 16, 2024

For reference:

Here's a screenshot of JSX React on PatternFly's demo page @ https://www.patternfly.org/components/helper-text/react-demos

image

@ashutosh7i
Copy link
Author

sure @garrett i am onto it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants