Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditionals from profiling #1302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove conditionals from profiling #1302

wants to merge 1 commit into from

Conversation

Izaakwltn
Copy link
Collaborator

There are still a few interior conditionals but nothing that affects the outward interface.

library/system.lisp Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
@Izaakwltn Izaakwltn force-pushed the profiling-fix branch 2 times, most recently from 28f190e to bc3d762 Compare October 11, 2024 06:47
library/system.lisp Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
@Izaakwltn Izaakwltn force-pushed the profiling-fix branch 4 times, most recently from 83c11f4 to 213f57f Compare October 14, 2024 17:01
Copy link
Member

@stylewarning stylewarning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nits and polish

library/system.lisp Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Show resolved Hide resolved
@Izaakwltn Izaakwltn force-pushed the profiling-fix branch 2 times, most recently from 187aafb to 65aaee3 Compare October 14, 2024 17:42
@Izaakwltn Izaakwltn force-pushed the profiling-fix branch 2 times, most recently from 140547d to 81beab0 Compare October 14, 2024 20:51
Copy link
Member

@stylewarning stylewarning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more bits and bobs

library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
library/system.lisp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants