-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move pi to trig and e to exp, fix atan2 #1012
Conversation
63091a4
to
346de73
Compare
87d98ae
to
2cffe14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this current rev actually type check? It seems like a type error to call BFConst
on something that's not Unit -> Big-Float
. See comments herein.
I'm concerned about why this program is type checking... |
Sorry for the noise. The tests are failing for Allegro. You can try testing with |
e69ec3d
to
896e930
Compare
Tests are all passing now, and default Big-Float |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few little things but I think they ought to be addressed for standard library cleanliness
80ce394
to
2405b94
Compare
2405b94
to
738b6a8
Compare
There are some types that need
pi
ore
but shouldn't needComplex
orPolar
in order to satisfyElementary
to get them.This shouldn't break external code, since Elementary will be a marker class and will still contain them.
@stylewarning
I've also checked this against
cl-quil/discrete
and it doesn't seem to have broken anything.