-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initial Gabriel Benchmarks #1000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting these over
(declare (optimize speed)) | ||
(loop :repeat 1000 | ||
:do (with-benchmark-sampling | ||
(coalton:coalton (coalton-benchmarks/native:stak 18 12 6)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add type annotations and then you can call the function directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
d81ca49
to
83af3e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lisp functions should also have type annotations to keep the benchmarks fair
|
||
(cl:declaim (cl:optimize (cl:speed 3) (cl:safety 0))) | ||
|
||
(coalton-toplevel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be a reasonable benchmark every coalton function in this file should have type annotations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, this afternoon's zen garden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added type annotations to every coalton and lisp function
5314963
to
2153b49
Compare
2153b49
to
caaf1a4
Compare
caaf1a4
to
bb34046
Compare
Here are the first few Gabriel Benchmarks implemented in Coalton (and lisp).
I also added a README with the basic running process.