Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial Gabriel Benchmarks #1000

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Added initial Gabriel Benchmarks #1000

merged 1 commit into from
Oct 4, 2023

Conversation

Izaakwltn
Copy link
Collaborator

Here are the first few Gabriel Benchmarks implemented in Coalton (and lisp).

I also added a README with the basic running process.

Copy link
Collaborator

@eliaslfox eliaslfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting these over

benchmarks/gabriel-benchmarks/stak.lisp Outdated Show resolved Hide resolved
(declare (optimize speed))
(loop :repeat 1000
:do (with-benchmark-sampling
(coalton:coalton (coalton-benchmarks/native:stak 18 12 6))))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type annotations and then you can call the function directly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

coalton.asd Outdated Show resolved Hide resolved
Copy link
Collaborator

@eliaslfox eliaslfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lisp functions should also have type annotations to keep the benchmarks fair


(cl:declaim (cl:optimize (cl:speed 3) (cl:safety 0)))

(coalton-toplevel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be a reasonable benchmark every coalton function in this file should have type annotations.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, this afternoon's zen garden

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added type annotations to every coalton and lisp function

@Izaakwltn Izaakwltn force-pushed the gabriel-benchmarks branch 2 times, most recently from 5314963 to 2153b49 Compare October 4, 2023 22:37
@Izaakwltn Izaakwltn merged commit 88ba669 into main Oct 4, 2023
17 checks passed
@Izaakwltn Izaakwltn deleted the gabriel-benchmarks branch October 4, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants