Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the yaml importer load multiple languages. #1253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

veluca93
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.41%. Comparing base (7db9aa1) to head (02112a0).
Report is 6 commits behind head on master.

Files Patch % Lines
cmscontrib/loaders/italy_yaml.py 6.66% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1253      +/-   ##
==========================================
- Coverage   69.45%   69.41%   -0.04%     
==========================================
  Files         328      328              
  Lines       26196    26208      +12     
==========================================
- Hits        18195    18193       -2     
- Misses       8001     8015      +14     
Flag Coverage Δ
functionaltests 46.99% <0.00%> (-0.22%) ⬇️
unittests 56.79% <17.64%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +382 to +383
if lang_code == primary_language:
continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this would mean that when no primary_language is specified in the task.yaml and the following files are present in the statement folder:

  • english.pdf
  • french.pdf
  • italian.pdf
  • spanish.pdf

We would actually only import 3 files (skipping italian.pdf). Is it correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no actually it would fail with "Couldn't find any task statement, aborting".

Still, maybe the logic can be changed so that if statement.pdf / testo.pdf are both missing, we don't immediately fail if there are other usable statement files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to make that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants