Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make no-conf apply to isolate config as well #1175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ranaldmiao
Copy link
Contributor

@ranaldmiao ranaldmiao commented Apr 10, 2021

Currently, when running sudo python3 prerequisites.py install --no-conf, configuration files for isolate will be re-installed.

This PR introduces a change for --no-conf to also be applied to isolate configuration files.
When --no-conf argument is provided, isolate configuration files will not be installed.


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #1175 (ccf69c7) into master (98cf097) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1175      +/-   ##
==========================================
+ Coverage   63.64%   63.70%   +0.05%     
==========================================
  Files         232      232              
  Lines       17046    17046              
==========================================
+ Hits        10849    10859      +10     
+ Misses       6197     6187      -10     
Flag Coverage Δ
functionaltests 47.59% <ø> (+0.01%) ⬆️
unittests 44.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cms/server/contest/handlers/contest.py 86.40% <0.00%> (-3.89%) ⬇️
cms/server/contest/handlers/tasksubmission.py 48.63% <0.00%> (-1.64%) ⬇️
cms/service/workerpool.py 70.00% <0.00%> (-1.12%) ⬇️
cms/db/fsobject.py 76.51% <0.00%> (-0.76%) ⬇️
cms/db/submission.py 97.93% <0.00%> (-0.52%) ⬇️
cms/io/rpc.py 93.19% <0.00%> (-0.35%) ⬇️
cms/db/filecacher.py 77.41% <0.00%> (ø)
cms/server/admin/handlers/base.py 69.63% <0.00%> (+0.66%) ⬆️
cms/grading/Job.py 90.17% <0.00%> (+0.89%) ⬆️
cms/service/ProxyService.py 68.68% <0.00%> (+1.01%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98cf097...ccf69c7. Read the comment docs.

@andreyv
Copy link
Member

andreyv commented Apr 13, 2021

Thanks.

The general idea is good, but I think it breaks the

./prerequisites.py install_isolate

subcommand. This should be easy to fix, though.

@ranaldmiao
Copy link
Contributor Author

Thanks.

The general idea is good, but I think it breaks the

./prerequisites.py install_isolate

subcommand. This should be easy to fix, though.

Good point, let me fix that and update you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants