Show number of days left for long lasting contests. #1094
Conversation
…king clock, when more than 72 hours are left in the contest.
Codecov Report
@@ Coverage Diff @@
## master #1094 +/- ##
==========================================
- Coverage 62.2% 61.98% -0.22%
==========================================
Files 229 230 +1
Lines 16520 16585 +65
==========================================
+ Hits 10276 10280 +4
- Misses 6244 6305 +61
Continue to review full report at Codecov.
|
|
Not everyone speaks uses English language. "days" should use the same translation mechanism as everything else. |
|
Maybe a good solution could be to show DD:HH:MM:SS instead of HH:MM:SS No translation mechanism needed, would still retain the "precise" feeling, while at the same time solving the problem of "72 hours left"... OR... we could just use a library to handle both the "humanization" of the time and its localization (e.g. moment or luxon) |
The issue I have with the current system (besides the many hours that are left for a contest that lasts for two weeks) is that the ticking hours, minutes and seconds distract from the fact that they have plenty of time left. I can definitely live with using moment.js or something similar, but even then you'd have to figure out what you want to show when. The way the system works is great for short term contests, but a bit over precise for longer term things. |
There was a problem hiding this comment.
I agree the seconds ticking might be unnerving, especially, but not only, when there are several days left :)
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @eljakim)
cms/server/contest/static/cws_utils.js, line 219 at r2 (raw file):
if (days <= 2) { // if less than 72 hours left, return the exact number of hours.
Proper indentation and capitalization please.
cms/server/contest/static/cws_utils.js, line 225 at r2 (raw file):
} else { // otherwise only return the number of days.
Ditto
cms/server/contest/templates/contest.html, line 153 at r2 (raw file):
</div> <div style="display: none" id="translation_days"> {% trans %}days{% endtrans %}
I think you need to translate %d days as some language might invert the order... I'm not sure there is a better way to do it in JS, but then I'd just to a replace("%d", days). @lerks for his extensive localization knowledge.
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @stefano-maggiolo)
cms/server/contest/static/cws_utils.js, line 219 at r2 (raw file):
Previously, stefano-maggiolo (Stefano Maggiolo) wrote…
Proper indentation and capitalization please.
Done.
cms/server/contest/static/cws_utils.js, line 225 at r2 (raw file):
Previously, stefano-maggiolo (Stefano Maggiolo) wrote…
Ditto
Done.
cms/server/contest/templates/contest.html, line 153 at r2 (raw file):
Previously, stefano-maggiolo (Stefano Maggiolo) wrote…
I think you need to translate
%d daysas some language might invert the order... I'm not sure there is a better way to do it in JS, but then I'd just to areplace("%d", days). @lerks for his extensive localization knowledge.
I don't know if I would want to put this in now. Would you prefer to go this way immediately, or can I do that in a later feature?
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eljakim)
cms/server/contest/templates/contest.html, line 153 at r2 (raw file):
Previously, eljakim (Eljakim Schrijvers) wrote…
I don't know if I would want to put this in now. Would you prefer to go this way immediately, or can I do that in a later feature?
Yeah, please go on with the change.
When a contest lasts for a couple of weeks, showing the exact number of seconds counting down is strange and distracting. This change keeps everything as it was if there are less than 72 hours left in a contest. However, when there is more time left it only displays the number of days left.
This change is