Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for task statement in HTML and MD #1086

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wil93
Copy link
Member

@wil93 wil93 commented Nov 29, 2018

I tested adding (from AWS and from CLI) and removing (from AWS), and tested the rendering.

If you like this change, I think the only change needed is to write the DB updater (and "vendorize" the new JS dependencies, I didn't do it here because I didn't want to push big files).

  • make sure that AWS supports uploading the new statement types
  • fix cmsAddStatement not fetching assets

This change is Reviewable

@CristianCantoro
Copy link
Contributor

CristianCantoro commented Dec 2, 2018

FWIW, we are already using Markdown for task statements. We using pandoc and a .tex template in the middle, so we generate the task statements separately with a Makefile.

@CristianCantoro
Copy link
Contributor

Example statement in Markdown, with PDF output:

@stefano-maggiolo
Copy link
Member

Let's try to merge #1067 first

@wil93
Copy link
Member Author

wil93 commented Jan 16, 2019

Now that #1067 is merged, maybe this can be considered 😃

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #1086 into master will decrease coverage by 19.89%.
The diff coverage is 19.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
- Coverage   61.99%   42.09%   -19.9%     
==========================================
  Files         228      230       +2     
  Lines       16460    16711     +251     
==========================================
- Hits        10204     7035    -3169     
- Misses       6256     9676    +3420
Flag Coverage Δ
#functionaltests ?
#unittests 42.09% <19.54%> (-1.07%) ⬇️
Impacted Files Coverage Δ
cms/server/admin/handlers/__init__.py 0% <ø> (-100%) ⬇️
cms/server/contest/handlers/__init__.py 100% <ø> (ø) ⬆️
cms/server/admin/handlers/task.py 0% <0%> (-41.02%) ⬇️
cms/db/__init__.py 96.42% <100%> (ø) ⬆️
cms/__init__.py 100% <100%> (ø) ⬆️
cms/server/contest/handlers/task.py 31.25% <12.19%> (-12.23%) ⬇️
cmscontrib/AddStatement.py 21.66% <20%> (-51.42%) ⬇️
cmscontrib/loaders/italy_yaml.py 7.89% <8.33%> (-0.06%) ⬇️
cms/db/task.py 73.15% <91.66%> (-8.6%) ⬇️
cms/server/admin/__init__.py 0% <0%> (-100%) ⬇️
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e7a87...fd0acd8. Read the comment docs.

The AWS html template generates 'wrong' field names since now we have both the language and
the file type, and the template uses only the language. We should change the template but
for now I just extract the language key from the full (lang, type) key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants