Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: elasticache_subnet_group creation #79

Merged
merged 2 commits into from
May 8, 2024

Conversation

flightlesstux
Copy link
Contributor

what

  • If we pass elasticache_subnet_group_name, the aws_elasticache_subnet_group.default[0] won't be created anymore

why

  • Who needs a new elasticache_subnet_group even we already created before and just want to pass a name

references

@flightlesstux flightlesstux requested review from a team as code owners May 7, 2024 20:54
@flightlesstux flightlesstux changed the title fix: elasticache_subnet_group creation #78 fix: elasticache_subnet_group creation May 7, 2024
@mergify mergify bot added the triage Needs triage label May 7, 2024
@gberenice
Copy link
Contributor

/terratest

Copy link
Contributor

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the same logic as we have in terraform-aws-elasticache-redis, which makes sense to me.

@gberenice gberenice merged commit 368c938 into cloudposse:main May 8, 2024
10 checks passed
@mergify mergify bot removed the triage Needs triage label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants