Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support profiles in default videoPlayer method #662

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

tsi
Copy link
Collaborator

@tsi tsi commented Jun 17, 2024

This PR suggests an alternative to #658, preventing a breaking change.

Usage example: https://codepen.io/tsi/pen/xxNpmNY?editors=0010

Co-Authored-By: Tsachi Shlidor <[email protected]>
Co-Authored-By: cloudinary-jenkins <[email protected]>
@tsi tsi self-assigned this Jun 17, 2024
@tsi tsi requested a review from a team as a code owner June 17, 2024 13:07
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit 5f7da6e
🔍 Latest deploy log https://app.netlify.com/sites/cld-video-player/deploys/667035273bd252000992e2cd
😎 Deploy Preview https://deploy-preview-662--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit 5f7da6e
🔍 Latest deploy log https://app.netlify.com/sites/cld-vp-esm-pages/deploys/66703527942e4d0007c98f52
😎 Deploy Preview https://deploy-preview-662--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tsi tsi requested review from jakub-roch and ehab-cl June 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant