Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker file added #96

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Docker file added #96

merged 2 commits into from
Oct 14, 2024

Conversation

gagandeepp
Copy link
Contributor

@gagandeepp gagandeepp commented Oct 13, 2024

Brief Summary of Changes

Add Docker file for the cloudinary-cli
Closes: #25

What does this PR address?

  • GitHub issue (Add reference - #XX)
  • Refactoring
  • New feature
  • Bug fix
  • Adds more tests

Are tests included?

  • Yes
  • No

Reviewer, please note:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

@gagandeepp
Copy link
Contributor Author

@laurenskling @const-cloudinary Please review the MR

Copy link
Contributor

@const-cloudinary const-cloudinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gagandeepp
Copy link
Contributor Author

@const-cloudinary can you please add Hacktoberfest label to this?

@const-cloudinary const-cloudinary merged commit 04c4a39 into cloudinary:master Oct 14, 2024
7 checks passed
@const-cloudinary
Copy link
Contributor

@gagandeepp Thank you for contribution!

@const-cloudinary
Copy link
Contributor

const-cloudinary commented Oct 14, 2024

@const-cloudinary can you please add Hacktoberfest label to this?

@gagandeepp I think it should be automatically counted, but I'll check.

@colbyfayock
Copy link

@gagandeepp the label is added to the repository level, its not necessary to add to the issue

thanks for your contribution. this PR is eligible for free Cloudinary Hackatoberfest swag. Please send me an email at [email protected] with your name, GitHub username, and a link to the PR where I'll send further instructions.

Happy Hacktoberfest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image containing cloudinary-cli
3 participants