Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

Ability to set custom column className for #465 #525

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AndrewEastwood
Copy link

No description provided.

@AndrewEastwood
Copy link
Author

Hey @wyuenho! What's about this?

@jamiepenney
Copy link

This would be really handy for me too. We have a standard table style, and rather than copying all those styles to the backgrid css classes (and hoping there are no overlaps in naming since they have very generic class names) I'm trying to replace as many of the CSS classes as I can.

@AndrewEastwood
Copy link
Author

It seems that @wyuenho is no longer with this stuff 😞

@wyuenho
Copy link
Contributor

wyuenho commented Mar 9, 2016

@AndrewEastwood I wasn't, and I am now :)

@AndrewEastwood
Copy link
Author

Hey man! How have you manged to get extremely long vacation? LOL

@wyuenho
Copy link
Contributor

wyuenho commented Mar 9, 2016

It's called a priority change :)

@wyuenho
Copy link
Contributor

wyuenho commented Mar 9, 2016

This PR is a very nice addition, but probably not enough. It seems that people often just want to do slight customizations on the default HeaderCell and Cell instances. What do you think of providing something like this?

var columns: [{
  name: 'title',
  label: 'Title',
  headerCellOptions: {...}.
  cellOptions: {...}
}, {...}];

@AndrewEastwood
Copy link
Author

agree

@AndrewEastwood
Copy link
Author

I'll change it

@jamiepenney
Copy link

Hey @wyuenho, welcome back!

@frozenspider
Copy link

frozenspider commented May 11, 2016

I'll love to have that as well, custom CSS class in cells would be nice without having to override a Cell class

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants