Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WC-2695 Add better visibility for router-worker #6941

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WillTaylorDev
Copy link

@WillTaylorDev WillTaylorDev commented Oct 10, 2024

What this PR solves / how to test

Fixes #WC-2695

This commit instruments the router worker with analytics such as request time, colo metadata, error, etc, in order for us to have better visibility into the router worker.

These changes were tested using gradual rollouts with a 0% version and a Cloudflare-Workers-Version-Overrides header.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: not a unit-testable change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@WillTaylorDev WillTaylorDev requested a review from a team as a code owner October 10, 2024 15:44
Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 3d5d8fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/workers-shared Minor
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-2695-add-worker-visibility branch from 93a0135 to 3f6da9d Compare October 10, 2024 16:16
Copy link
Contributor

github-actions bot commented Oct 10, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-wrangler-6941

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6941/npm-package-wrangler-6941

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-wrangler-6941 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-create-cloudflare-6941 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-cloudflare-kv-asset-handler-6941
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-miniflare-6941
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-cloudflare-pages-shared-6941
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-cloudflare-vitest-pool-workers-6941
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-cloudflare-workers-editor-shared-6941
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11278412769/npm-package-cloudflare-workers-shared-6941

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.1
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

This commit instruments the router worker with analytics such
as request time, colo metadata, error, etc, in order for us to
have better visibility into the router worker.

These changes were tested using gradual rollouts with a 0% version
and a Cloudflare-Workers-Version-Overrides header.
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-2695-add-worker-visibility branch from 3f6da9d to 3d5d8fa Compare October 10, 2024 16:45
@emily-shen emily-shen added the e2e Run e2e tests on a PR label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

4 participants