feat: add programmatic API for types #6861
Conversation
|
| outFile?: string; | ||
| persistToFilesystem?: boolean; | ||
| }): Promise<string> { | ||
| return generateTypes(getProjectTypes, options); |
There was a problem hiding this comment.
Where does getProjectTypes come from?
There was a problem hiding this comment.
This is not yet implemented. It would be an abstraction that isolates some of the logic already existing inside the type generation code. Basically just gets a string of the Env types.
(I don't know if "Project" is the right word here. Could also go with "Env" or something else).
| getRuntimeTypes({ | ||
| compatibilityDate: config.compatibility_date, | ||
| compatibilityFlags: config.compatibility_flags.filter( | ||
| (flag) => !flag.includes("nodejs_compat") |
There was a problem hiding this comment.
Better to be explicit here, checking against nodejs_compat and nodejs_compat_v2
| if (!config && !configFile) { | ||
| throw new Error("Either config or configFile must be provided"); | ||
| } | ||
| if (config && configFile) { | ||
| throw new Error("Only one of config or configFile should be provided"); | ||
| } | ||
| if (outFile && persistToFilesystem === undefined) { | ||
| throw new Error( | ||
| "persistToFilesystem must be specified when outFile is provided" | ||
| ); | ||
| } |
There was a problem hiding this comment.
This combo have validation can be accomplished with union types
There was a problem hiding this comment.
Or overloads perhaps.
What this PR solves / how to test
Fixes #000.
Adds a programmatic API for type generation.
Author has addressed the following