Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate release of quick-edit when workers-types is updated #6852

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Sep 27, 2024

What this PR solves / how to test

Fixes #0000

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: reusing existing tested code
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: workflow
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because: workflow
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: workflow

@RamIdeas RamIdeas requested a review from a team as a code owner September 27, 2024 18:25
Copy link

changeset-bot bot commented Sep 27, 2024

⚠️ No Changeset found

Latest commit: 7d91187

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines 28 to 29
- name: Generate quick-edit-extension changeset
run: node -r esbuild-register tools/dependabot/generate-dependabot-pr-changesets.ts ${{ github.event.number }} quick-edit-extension packages/quick-edit-extension/package.json dependabot-update-quick-edit-extension
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will create a changeset for quick-edit-extension when dependabot bumps it's workers-types dependency

@@ -25,5 +25,5 @@ jobs:
git config --global user.email [email protected]
git config --global user.name 'Wrangler automated PR updater'

- name: Generate Miniflare changesets
run: node -r esbuild-register tools/dependabot/generate-dependabot-pr-changesets.ts ${{ github.event.number }} miniflare packages/miniflare/package.json dependabot-update
- name: Generate Miniflare changeset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add to this script rather than creating a new one? Dependabot should always update these in one PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It updates the same PR but the file change that triggers the workflow is the package.json of the package – in this workflow it's miniflare's package.json, in the other it's quick-edit-extension's package.json that triggers the workflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I agree it would be nicer to have one workflow 107eae2

@@ -23,6 +23,7 @@
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"concurrently": "^8.2.2",
"quick-edit-extension": "workspace:*",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause changesets to bump the version of quick-edit when quick-edit-extension's version is bumped which will then cause it to be released with other packages/workers

Copy link
Contributor

github-actions bot commented Sep 27, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-wrangler-6852

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6852/npm-package-wrangler-6852

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-wrangler-6852 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-create-cloudflare-6852 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-cloudflare-kv-asset-handler-6852
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-miniflare-6852
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-cloudflare-pages-shared-6852
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-cloudflare-vitest-pool-workers-6852
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-cloudflare-workers-editor-shared-6852
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-cloudflare-workers-shared-6852

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.0
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@RamIdeas RamIdeas requested a review from penalosa October 3, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants