-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automate release of quick-edit when workers-types is updated #6852
base: main
Are you sure you want to change the base?
Conversation
|
- name: Generate quick-edit-extension changeset | ||
run: node -r esbuild-register tools/dependabot/generate-dependabot-pr-changesets.ts ${{ github.event.number }} quick-edit-extension packages/quick-edit-extension/package.json dependabot-update-quick-edit-extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will create a changeset for quick-edit-extension when dependabot bumps it's workers-types dependency
@@ -25,5 +25,5 @@ jobs: | |||
git config --global user.email [email protected] | |||
git config --global user.name 'Wrangler automated PR updater' | |||
|
|||
- name: Generate Miniflare changesets | |||
run: node -r esbuild-register tools/dependabot/generate-dependabot-pr-changesets.ts ${{ github.event.number }} miniflare packages/miniflare/package.json dependabot-update | |||
- name: Generate Miniflare changeset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add to this script rather than creating a new one? Dependabot should always update these in one PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It updates the same PR but the file change that triggers the workflow is the package.json of the package – in this workflow it's miniflare's package.json, in the other it's quick-edit-extension's package.json that triggers the workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I agree it would be nicer to have one workflow 107eae2
@@ -23,6 +23,7 @@ | |||
"devDependencies": { | |||
"@cloudflare/workers-tsconfig": "workspace:*", | |||
"concurrently": "^8.2.2", | |||
"quick-edit-extension": "workspace:*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause changesets to bump the version of quick-edit when quick-edit-extension's version is bumped which will then cause it to be released with other packages/workers
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-wrangler-6852 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6852/npm-package-wrangler-6852 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-wrangler-6852 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-create-cloudflare-6852 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-cloudflare-kv-asset-handler-6852 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-miniflare-6852 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-cloudflare-pages-shared-6852 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-cloudflare-vitest-pool-workers-6852 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-cloudflare-workers-editor-shared-6852 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11077202919/npm-package-cloudflare-workers-shared-6852 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
What this PR solves / how to test
Fixes #0000
Author has addressed the following