Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lru: using max to simplify the if statement #130

Closed
wants to merge 2 commits into from
Closed

lru: using max to simplify the if statement #130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d2613d
lru: using max to simplify the if statement
cppcoffee Mar 11, 2024
d624d90
Merge branch 'cloudflare:main' into lru
cppcoffee Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pingora-lru/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ impl<T, const N: usize> Lru<T, N> {

// Make sure weight is positive otherwise eviction won't work
// TODO: Probably should use NonZeroUsize instead
let weight = if weight == 0 { 1 } else { weight };
let weight = weight.max(1);

let old_weight = unit.admit(key, data, weight);
if old_weight != weight {
Expand Down