Update to Kotlin 1.9.22 and migrate to Kotlin/Wasm #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irvinebroque
commented
Mar 7, 2024
irvinebroque
commented
Mar 7, 2024
Co-authored-by: Brendan Irvine-Broque <[email protected]>
* Change wording. * Update some links. * Add some other useful links.
Since ~3.46.0 wrangler is modifying an exported object, but wasm instance.exports is not modifiable, and it leads to runtime error. Also: * Make it compatible with both Kotlin 1.9.2x and upcoming 2.0.0. * For 2.0.0 don't use default export to avoid errors in the console.
Hi 👋 Kotlin/Wasm requires Node 22+ https://youtrack.jetbrains.com/issue/KT-65864. In Kotlin 2.0 the default Node version has been updated to 22, so updating Kotlin will fix this issue.
Oops, sorry, I didn't see that this PR already contained this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncaught Error: Supported JS engine not detectedwhen running in dev or deployingIs it this?
https://github.com/JetBrains/kotlin/blob/7d4ad9d9f9b895cdf0310c1c7614402ab87d449a/compiler/ir/backend.wasm/src/org/jetbrains/kotlin/backend/wasm/compiler.kt#L301-L303