Skip to content

Adjust reporting of connection failure metric (#389) #487

Adjust reporting of connection failure metric (#389)

Adjust reporting of connection failure metric (#389) #487

Triggered via push September 1, 2023 21:38
Status Success
Total duration 3m 27s
Artifacts

go.yml

on: push
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

10 errors
lint: client/client.go#L391
exported function DefaultLoadPubKey should have comment or be unexported
lint: client/keys.go#L68
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
lint: client/keys.go#L74
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
lint: client/remote.go#L141
exported func GetConnPool returns unexported type *client.connPoolType, which can be annoying to use
lint: cmd/gokeyless/gokeyless.go#L243
error strings should not be capitalized or end with punctuation or a newline
lint: cmd/gokeyless/gokeyless.go#L406
receiver name config should be consistent with previous receiver name c for Config
lint: cmd/gokeyless/gokeyless.go#L427
receiver name config should be consistent with previous receiver name c for Config
lint: internal/test/params/params.go#L25
exported var RSAMD5SHA1Params should have comment or be unexported
lint: internal/test/params/params.go#L49
exported var ECDSASHA224Params should have comment or be unexported
lint: internal/test/params/params.go#L69
exported var ECDSAURI should have comment or be unexported