LITE-28324 Fix --version check for updates #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdjilka
force-pushed
the
lite-28324-fix-ccli-version
branch
4 times, most recently
from
ed84371
to
154e398
Compare
ffaraone
previously approved these changes
Aug 8, 2023
connect/cli/core/utils.py
Outdated
| if last_version and last_version != current: | ||
| console.echo() | ||
| console.secho( | ||
| f'You are running CloudBlue Connect CLI version {current}. ' | ||
| f'A newer version is available: {last_version}', | ||
| f'Suggested latest version for used Connect version: {last_version}', |
There was a problem hiding this comment.
Why you changed the message ?
There was a problem hiding this comment.
I would suggest the following:
WARNING: You are running an outdated version ({current}) of CloudBlue Connect CLI.
A newer version ({last_version}) is available and includes new features and security fixes.
Please upgrade your current version to the {last_version}.
Wdyt ?
There was a problem hiding this comment.
In theory user cannot choose the Connect version, they always use the version deployed to production.
ffaraone
reviewed
Aug 8, 2023
bdjilka
force-pushed
the
lite-28324-fix-ccli-version
branch
from
154e398
to
582d9ac
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ffaraone
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.