Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/english particle verbs to dev #314

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

JakobSteixner
Copy link

@JakobSteixner JakobSteixner commented Oct 7, 2020

Correct results for pattern.en.lemma/pattern.en.conjugate/pattern.en.tenses with particle verbs by splitting the input into verb stem and sattelites (first word and everything else) before doing the base class _Verb processing.

example:

>>> import pattern.en as enp
>>> print(enp.conjugate("dispose of", list(enp.tenses("discarded"))[0])) # old result was: 'dispose offed'
'disposed of'

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 68.392% when pulling 9a51869 on JakobSteixner:fix/english-particle-verbs-to-dev into 17f2154 on clips:development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants