Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localization): Add en-GB #4313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ijxy
Copy link

@ijxy ijxy commented Oct 10, 2024

Description

Replaces a couple of "Americanisms" with their British versions:

  • authorize with authorise
  • organization with organisation

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 759dd6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Minor
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ijxy ijxy force-pushed the feat/localizations/add-en-GB branch 3 times, most recently from 4658f7c to 3fdcdef Compare October 10, 2024 16:22
Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijxy Thank you for this! Please just update the major changeset to minor, and we should be good to go!

.changeset/fuzzy-carrots-push.md Outdated Show resolved Hide resolved
Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the changes of generate.ts file.

@ijxy ijxy force-pushed the feat/localizations/add-en-GB branch from 2445633 to 900336f Compare October 25, 2024 16:22
@ijxy
Copy link
Author

ijxy commented Oct 25, 2024

@anagstef @tmilewski Apologies for the delay–I have updated as per comments and extracted the changed words into a little dictionary object so it is easier to see what is actually changed.

The tl;dr is that now the enGB locale data should automatically stay up to date with any changes to enUS. 🎉

@ijxy ijxy force-pushed the feat/localizations/add-en-GB branch from 900336f to 759dd6d Compare October 25, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants